undefined | Better HN

0 pointsmkishi11y ago0 comments

> The preferred action is to allocate on the caller's heap and pass a mutable reference down to the callee.

Care to link/elaborate this? I thought the recommendation was to return by value in this case -- making it easy for the caller to decide where to store the value. The move semantics would then optimize the copy away, so you end up using either the caller's stack or the heap, depending on how the call was made.

0 comments

steveklabnik11y ago

You're correct.

mkishiOP11y ago

Actually, I got curious and tried it out. Turns out Rust didn't optimize the heap case: it used the caller's stack, and only then copied the value to the heap.

https://play.rust-lang.org/?code=%23!%5Bfeature(core)%5D%0A%...

pcwalton11y ago

Because it would change the semantics of the program. Where heap allocations happen is considered a side effect, and forcing a function to be inline(never) also makes it have unconstrained side effects (in some cases). Those side effects cannot be reordered.

steveklabnik11y ago

That's because of `Box::new`, I'd think. If you use the box keyword, you should get the placement new effect.

1 more reply

j / k navigate · click thread line to collapse

0 pointsmkishi11y ago0 comments

> The preferred action is to allocate on the caller's heap and pass a mutable reference down to the callee.

0 comments

steveklabnik11y ago

You're correct.

mkishiOP11y ago

Actually, I got curious and tried it out. Turns out Rust didn't optimize the heap case: it used the caller's stack, and only then copied the value to the heap.

https://play.rust-lang.org/?code=%23!%5Bfeature(core)%5D%0A%...

pcwalton11y ago

steveklabnik11y ago

That's because of `Box::new`, I'd think. If you use the box keyword, you should get the placement new effect.

1 more reply

j / k navigate · click thread line to collapse