undefined | Better HN

0 pointsenjo11y ago0 comments

That's exactly right. It's not about pushing meaningful or complex code to production, it's about pushing a small change so that a new engineer can see the whole process from end-to-end.

We do have people push on their first day here at Gridium and I think it's really beneficial. The new engineer sees how we work, and the rest of the team sees that new name in the git logs, on chat, and everywhere else. It sends a strong message that there is a new member of the team who is going to be contributing from now on. It helps to establish cultural norms (everyone makes a big deal out of that first commit which is fun).

I really like the effect it has on our team. Even changing two characters in a string feels like a big deal and that's awesome.

0 comments

5 comments · 1 top-level

frostmatthew11y ago· 4 in thread

> it's about pushing a small change so that a new engineer can see the whole process from end-to-end

Is that really an accurate portrayal of the process though? Most changes aren't small and take days of development, not minutes or hours. Not to mention code reviews and QA.

mcfunley11y ago

Yes, it really is an accurate portrayal of the process. Etsy isn't pushing days of development out in a deploy. That would be considered poor practice at Etsy.

To make a sizable feature live, you use a bunch of methods in cooperation:

* Only mutate a bare minimum number of executed lines as code deploys.

* Turn features on and off quickly with (much faster) config deploys.

* Release and test features for internal users first (in production).

* Ramp features up to small amounts of production traffic at a time.

* Deploy new code paths and queries so that they're executed, but aren't visible to end users. (You can use this to detect performance problems early.)

But what you never do is sit on days of sizable code changes that you don't deploy. If you try to deploy a massive diff people in your push will generally suggest that you not do it.

frostmatthew11y ago

> But what you never do is sit on days of sizable code changes that you don't deploy.

That's certainly sensible but I wasn't suggesting sitting on "days of sizable code changes" - just that it takes days to make the code changes (particularly once you factor in code review and QA).

ulisesrmzroche11y ago

That's super Byzantine. Do you guys have a decent test structure? Probably wouldn't have to tip-toe around so much.

enjoOP11y ago

Most isn't all tho! At any time I can come up with a dozen really small fixes. Changing the timing of a task, updating a string, or any other small things that are always hanging around.

j / k navigate · click thread line to collapse