Skip to content

Top Best Ask Show New Jobs

Show HN: I made a tool that adds two-step verification to websites or apps

10 pointsyansuck12y ago12 comments

Hello!

I just made my first web app with Sinatra. It is a REST API that helps people add two-step verification to their websites or apps. I am a complete noob in web development so please criticize me and let me know how shitty this whole thing is. :)

http://two-step.herokuapp.com/

12 comments

10 comments · 4 top-level

jbrooksuk12y ago· 2 in thread

When you use the sign up form, why do you use a GET? This should be a POST.

yansuckOP12y ago

It's POST.

jbrooksuk12y ago

Ah yeah, you do a redirect with the ?message param.

Why not store this in a session?

h-go12y ago· 2 in thread

Thanks! This is awesome!

yansuckOP12y ago

Thanks! Did you find anything unpleasant? Anything that I could work on?

h-go12y ago

It would be nice if the email could be modified, but that's just a small thing. Or a custom message.

What language did you use, if you don't mind my asking?

dham12y ago· 1 in thread

Just a heads up, you're still using Webrick. Looks good though!

https://devcenter.heroku.com/articles/getting-started-with-r...

yansuckOP12y ago

I am sorry I am pretty new to rails. What's bad about using Webrick? I thought it is the default.

arkokoley12y ago· 1 in thread

This looks good! Will be helpful! Thanks, great job!

yansuckOP12y ago

Thank you :)

j / k navigate · click thread line to collapse