Show HN: Example implementation of Mozilla's persona and Go server (opens in new tab)

(github.com)

38 pointssauerbraten12y ago6 comments

6 comments

I didn't realize this, but this is a Persona client library not a Persona server. Not sure why I confused them, but figure it was worth mentioning.

sauerbratenOP12y ago

Yeah, I worded it differently when I submitted it to /r/golang: Example of using Mozilla's persona with Go

krf12y ago

I'm new to Go but shouldn't the defer rawResp.Body.Close() be done after the error checking. If there is an error wouldn't rawResp be nil ?

sauerbratenOP12y ago

You're right. Fixed it, thanks!

realrocker12y ago

Yup. It should be closed or it will probably leak memory in a few hours.

sauerbratenOP12y ago

Not really. Memory would only be leaked if there really was an error and rawResp was still nil. Since this usually doesn't happen (at least it never happened to me), you probably wouldn't even have noticed this bug.

j / k navigate · click thread line to collapse

6 comments

trebor12y ago

I didn't realize this, but this is a Persona client library not a Persona server. Not sure why I confused them, but figure it was worth mentioning.

sauerbratenOP12y ago

Yeah, I worded it differently when I submitted it to /r/golang: Example of using Mozilla's persona with Go

krf12y ago

I'm new to Go but shouldn't the defer rawResp.Body.Close() be done after the error checking. If there is an error wouldn't rawResp be nil ?

sauerbratenOP12y ago

You're right. Fixed it, thanks!

realrocker12y ago

Yup. It should be closed or it will probably leak memory in a few hours.

sauerbratenOP12y ago

j / k navigate · click thread line to collapse