undefined | Better HN

0 pointschimeracoder12y ago0 comments

Caveat: This will yield different results whether you initialize the string as

> String a = "foo";

vs.

> String a = new String("foo");

0 comments

fyi8012y ago

Parent wrote:

"Any two identical literals"

The second 'a' is not a literal.

RyanZAG12y ago

The OP is still correct though - don't use == for strings, always use .equals()

The problem with using == is maintainability and silent failure. Someone may change the program to accept the string from the command line, or just about anything else. As soon as this happens, a string can come in from elsewhere and still have the value "yes" but would still pass the inequality.

This bug would be completely silent and incredibly difficult to debug, possibly only arising in strange and unusual circumstances. The only way to really avoid this is to just use .equals() always. Using == for strings in Java is plain terrible coding, and the OP is therefore correct.

j / k navigate · click thread line to collapse