I don’t think the argument as a whole is a fallacy, it’s true that the exact cost to the NHS is more than covered by tax, but most estimates of wider cost to the economy (e.g. lost productivity, disability benefits, etc) is higher.
https://fullfact.org/health/farage-smoking-revenue-nhs/