I don't disagree with this, but I also think it's because the battery often dies around the time most people would consider upgrading anyway. The battery isn't the only reason people upgrade, it's just a forcing factor.
If batteries normally last 3-5 years, I don't think we're going to start seeing most people keep their phones for 7-10 years. I still think we're going to see people upgrading around the 3-5 year mark. I would point to the current market as evidence of this. An iPhone battery replacement is somewhere between $50-$100 right now which is drastically cheaper than a new iPhone and yet we still see the 3-5 year upgrade cycle. Maybe making it something you can do at home in a few minutes will result in a few more people just choosing to replace the battery vs the entire phone, but I don't see it drastically changing things since a cheap alternative to replacing the phone already exists and yet we still see the 3-5 year replacement cycle.