undefined | Better HN

0 pointsTyr4216d ago0 comments

Heck, doing a self review when you wrote the code catches stuff like forgetting debug prints.

0 comments

(tangent of the decade : prefixing your debug printfs with NOCOMMIT helps catching them before commit :) sample precommit hook and GitHub ci action I wrote is at https://github.com/nobssoftware/nocommit but it’s just a grep)

therealdrag015d ago

Self review should also include adding guiding comments for other reviewers.

fireant15d ago

Do you add these into the code or into the review itself? I sometimes write these into the review, but I wonder if it's a useful information that should actually be inside the code that will get lost when the PR is merged

therealdrag014d ago

Into the review is what I’m talking about. The diff is often a scattered collection of files missing context, and may have refactors that obscure behavioral changes.

So there is reason to add comments that address a different readers understanding than the code rest.

j / k navigate · click thread line to collapse