undefined | Better HN

0 pointsdwattttt6mo ago0 comments

Sibling says this with code, but to distil the advice: reflect the result of your validation in the type system.

Then instead of validating a loose type & still using the loose type, you're parsing it from a loose type into a strict type.

The key point is you never need to look at a loose type and think "I don't need to check this is valid, because it was checked before"; the type system tracks that for you.

0 comments

8n4vidtmkvmk6mo ago

Everyone seems hung up on the type system, but I think the validity of the data is the important part. I'd still want to convert strings to ints, trim whitespace, drop extraneous props and all of that jazz even if I was using plain JS without types.

I still wouldn't need to check the inputs again because I know it's already been processed, even if the type system can't help me.

dwatttttOP6mo ago

The type isn't just there to make it easy to understand when you do it, it's for you a year later when you need to make a change further inside a codebase, far from where it's validated. Or for someone else who's never even seen the validation section of code.

I'm hung up on the type system because it's a great way to convey the validity of the data; it follows the data around as it flows through your program.

I don't (yet) Typescript, but jsdoc and linting give me enough type checking for my needs.

k3vinw6mo ago

jsdoc types are better than nothing. You could switch to using Typescript today and it will understand them.

hdjrudni6mo ago

Don't get me wrong, I love TypeScript types. And if I didn't have TypeScript, I'd use jsdoc.

I'm just saying that TypeScript and jsdoc don't actually do any runtime enforcement. It's important that the library does that part, with or without types.

Lvl999Noob6mo ago

Pure js without typescript also has "types". Typescript doesn't give you nominal types either. It's only structural. So when you say that you "know it's already been processed", you just have a mental type of "Parsed" vs "Raw". With a type system, it's like you have a partner dedicated to tracking that. But without that, it doesn't mean you aren't doing any parsing or type tracking of your own.

hdjrudni6mo ago

I don't think that's what people are talking about when they say types. They're talking about TypeScript types, not mental models of object structure.

j / k navigate · click thread line to collapse

0 pointsdwattttt6mo ago0 comments

Sibling says this with code, but to distil the advice: reflect the result of your validation in the type system.

Then instead of validating a loose type & still using the loose type, you're parsing it from a loose type into a strict type.

The key point is you never need to look at a loose type and think "I don't need to check this is valid, because it was checked before"; the type system tracks that for you.

0 comments

8n4vidtmkvmk6mo ago

I still wouldn't need to check the inputs again because I know it's already been processed, even if the type system can't help me.

dwatttttOP6mo ago

I'm hung up on the type system because it's a great way to convey the validity of the data; it follows the data around as it flows through your program.

I don't (yet) Typescript, but jsdoc and linting give me enough type checking for my needs.

k3vinw6mo ago

jsdoc types are better than nothing. You could switch to using Typescript today and it will understand them.

hdjrudni6mo ago

Don't get me wrong, I love TypeScript types. And if I didn't have TypeScript, I'd use jsdoc.

I'm just saying that TypeScript and jsdoc don't actually do any runtime enforcement. It's important that the library does that part, with or without types.

Lvl999Noob6mo ago

hdjrudni6mo ago

I don't think that's what people are talking about when they say types. They're talking about TypeScript types, not mental models of object structure.

j / k navigate · click thread line to collapse