undefined | Better HN

0 pointsxtdx13y ago0 comments

Indeed, I may have read the code wrong. But look at line 188.

    m_prevLink->m_nextNode = m_nextNode;

I don't see where m_prevLink is changed. If the previous link has gone away, and you call RemoveFromList on this node a second time, it's going to chase that pointer.

0 comments

Ogre13y ago

RemoveFromList is a private method. All the public methods, other than the destructor, that call it also modify m_prevLink.

j / k navigate · click thread line to collapse

0 pointsxtdx13y ago0 comments

Indeed, I may have read the code wrong. But look at line 188.

    m_prevLink->m_nextNode = m_nextNode;

I don't see where m_prevLink is changed. If the previous link has gone away, and you call RemoveFromList on this node a second time, it's going to chase that pointer.

0 comments

Ogre13y ago

RemoveFromList is a private method. All the public methods, other than the destructor, that call it also modify m_prevLink.

j / k navigate · click thread line to collapse