One data point I heard recently was 80% of Iranians oppose the current regime. That said I've also heard there is wide support for Iran to have a nuclear program. Presumably as a matter of national pride. I would still imagine the secular population to be less inclined to go to war with Israel in general.

The only Iranians I've personally talked to are ones that live in the west. They generally want to have peace with Israel and want to see the regime removed. Again very anecdotally they are still not happy about Israel bombing Iran but if the regime is actually somehow magically removed I don't think attacking Israel would be a high priority for a hypothetical secular or democratic regime.

I meant that demographically, if your populace isn't as poor, battle hardened and religious (like Afghanistan) maybe going into a long ground war is less politically feasible?

In Afghanistan they had basically just been fighting a war, where the last war in Iran was 30 years ago?