Skip to content
Better HN
Top
Best
Ask
Show
New
Jobs
Search
⌘K
0 points
codyvoda
1y ago
0 comments
Save
Share
the code goes through a PR review process like any other? what are you talking about?
0 comments
2 comments · 2 top-level
top
newest
oldest
fernandotakai
1y ago
i don't know about you, but i would never EVER submit a PR that fails to
compile
. not tests are failing, those happen (specially flaky ci), but not compiling.
that's literally the bare minimum.
1 more reply
nottorp
1y ago
so do you consider normal to submit code that you have never compiled? or ran at least once if it's not a compiled language...
j
/
k
navigate · click thread line to collapse