undefined | Better HN

0 pointssteveklabnik1y ago0 comments

I'm not an expert on this corner of git, but a guess: trailer keys are not unique, that is

  Signed-off-by: Alice <alice@example.com>
  Signed-off-by: Bob <bob@example.com>

is totally fine, but

  Change-id: wwyzlyyp
  Change-id: sopnqzkx

is not.

I've also heard of issues with people copy/pasting commit messages and including bits of trailers they shouldn't have, I believe.

0 comments

bananapub1y ago

~I think it's more that not all existing git commands (rebase, am, cherry-pick?) preserve all headers.~

ignore, misread the above

steveklabnikOP1y ago

That's a downside of using headers, not a reason for using them. If upstream git changes to help this, it would involve having those preserve the headers. (though cherry-pick has good arguments of preserving vs generating a new one)

bananapub1y ago

ah, I'm sorry, I misread your comment (and should have mentioned the cherry-pick thing anyway).

steveklabnikOP1y ago

It’s all good!

j / k navigate · click thread line to collapse

0 comments

bananapub1y ago

~I think it's more that not all existing git commands (rebase, am, cherry-pick?) preserve all headers.~

ignore, misread the above

steveklabnikOP1y ago

bananapub1y ago

ah, I'm sorry, I misread your comment (and should have mentioned the cherry-pick thing anyway).

steveklabnikOP1y ago

It’s all good!

j / k navigate · click thread line to collapse