undefined | Better HN

0 pointsge961y ago0 comments

I'm not in disagreement about being able to tell who wrote some piece of code, I like gitlens in my vscode for ex.

The feelings hurt thing is real, unfortunately for myself I am that person that gets butthurt but it's a phrasing thing, "why did you do this?" vs. something more neutral sounding like "hey this has this side effect are you aware".

Anyway unfortunately in my case too we're not allowed to write tests so it really is an exercise in omniscience.

0 comments

Minor49er1y ago

I'm curious if you have experienced people asking something as blunt and short-sighted as "why did you do this?" as the result of a blame. The blame should reveareveal the PR or commit that a change came from which should answer that question already

You should also write tests. They ensure that your code works as intended. Some teammates might not understand that untested code can cause more development time since broken features will have to be fixed in production, so highlighting bugs that have to be fixed as well as writing tests thst cover as many cases as possible should shine some light for those still not understanding their value

ge96OP1y ago

That's the thing, I used to think tests are annoying but now I'm advocating for em, maybe a sign of growing up ha. Unfortunately not my call. Yeah it's just tone, tone changes the outcome of some conversation. Puts person on defensive, stops thinking, that kind of thing.

1 more reply

j / k navigate · click thread line to collapse

0 comments

Minor49er1y ago

ge96OP1y ago

1 more reply

j / k navigate · click thread line to collapse