undefined | Better HN

0 pointsmeheleventyone1y ago0 comments

For a project with lots of variation being maintained by a single person that’s totally fine.

0 comments

Yep, there are days I yearn for just having a super long set of if statements, vs the over-engineered messes that I deal with on a daily basis.

So many codebases end up impenetrable in the pursuit of fancy design patterns...

npteljes1y ago

I think that too fancy code is just as bad as the original if-else spaghetti, but then even worse, because the patterns are abstract now as well.

npteljes1y ago

Bad code can have a really high cognitive load to maintain. Just to illustrate what bad means, take a look at this:

https://www.reddit.com/r/programminghorror/comments/1cb6rca/...

I can see that having even bits of modification impacts lots of lines, where if written just a bit more saner, it could impact just a few.

Of course everyone is absolutely free to do the things however they want on their project. It's just that bad code, and bad choices bite back sometimes really badly. Project Zomboid is built in LUA for example, and it shows, it's a horrorshow not just to play, but to develop it as well. Their programmers spend a lot of time with just refactoring things. Besides functionality, maintainability should be a huge focus in my experience, so that the devs don't hate life if they have to touch the code again.

meheleventyoneOP1y ago

The example you post is out of context and maybe a bit overly verbose but again it’s one guy maintaining it and is perfectly readable. Does anyone really struggle to understand that?

I’m back working on a twenty plus year old codebase (and game) that’s ~3 millions loc and would kill for something simple like that rather than some of the overabstracted crimes lurking within.

npteljes1y ago

The problem is not with understanding, but with maintainability. If you need, for any reason, to touch that code again, instead of a few changes, you have to be consistently doing a lot of changes. This has a higher chance of manual errors. And it has nothing to do with other bad code, like the one that you encounter. Both can be bad code, and what you inherited sounds worse. I hate it when the badness is compounded with complexity. It feels pretentious to me.

meheleventyoneOP1y ago

That code is a few lines maintaining a mapping though, changing it is not going to be hard and all the mappings are captured explicitly which makes it even more straightforward versus shaving off lines of code by making some of them implicit (e.g. by seeing a pattern in the mapping and using an if statement to capture them all). I'd really love to know what you think it should be to be more maintainable!

1 more reply

AnIrishDuck1y ago

Yeah, without context criticism of this code is silly.

What if this wasn't always how cards worked? What if the mapping was (at one point in development) not straightforward? Or localthunk had some ideas and wanted to leave the door open to a more complex mapping scheme?

npteljes1y ago

Either silly, or 20 years in the business.

j / k navigate · click thread line to collapse

0 comments

Trasmatta1y ago

Yep, there are days I yearn for just having a super long set of if statements, vs the over-engineered messes that I deal with on a daily basis.

So many codebases end up impenetrable in the pursuit of fancy design patterns...

npteljes1y ago

I think that too fancy code is just as bad as the original if-else spaghetti, but then even worse, because the patterns are abstract now as well.

npteljes1y ago

Bad code can have a really high cognitive load to maintain. Just to illustrate what bad means, take a look at this:

https://www.reddit.com/r/programminghorror/comments/1cb6rca/...

I can see that having even bits of modification impacts lots of lines, where if written just a bit more saner, it could impact just a few.

meheleventyoneOP1y ago

The example you post is out of context and maybe a bit overly verbose but again it’s one guy maintaining it and is perfectly readable. Does anyone really struggle to understand that?

I’m back working on a twenty plus year old codebase (and game) that’s ~3 millions loc and would kill for something simple like that rather than some of the overabstracted crimes lurking within.

npteljes1y ago

meheleventyoneOP1y ago

1 more reply

AnIrishDuck1y ago

Yeah, without context criticism of this code is silly.

npteljes1y ago

Either silly, or 20 years in the business.

j / k navigate · click thread line to collapse