undefined | Better HN

0 pointsjustinpombrio1y ago0 comments

> Can you spot all the problems?

You were probably being rhetorical, but there are two problems:

- `p = 2` should be outside the loop

- `prime_factors.append(n)` appends `1` onto the end of the list for no reason

With those two changes I'm pretty sure it's correct.

0 pointsjustinpombrio1y ago0 comments

> Can you spot all the problems?

You were probably being rhetorical, but there are two problems:

- `p = 2` should be outside the loop

- `prime_factors.append(n)` appends `1` onto the end of the list for no reason

With those two changes I'm pretty sure it's correct.

0 comments

5 comments · 2 top-level

kenjackson1y ago· 2 in thread

You don't need to append 'p' in the inner while loop more than once. Maybe instead of an array for keeping the list of prime factors do it in a set.

It’s valid to return the multiplicity of each prime, depending on the goal of this.

rmbyrro1y ago· 1 in thread

`n` isn't defined

The implicit context that the poster removed (as you can tell from the indentation) was a function definition:

    def factorize(n):
      ...
      return prime_factors

j / k navigate · click thread line to collapse