So really, terrorism is what people say is terrorism.
Could this possibly fall under Article 37 c of the Geneva convention (“The feigning of civilian, non-combatant status”)? In that case, calling it terrorism wouldn’t be too bizarre in my opinion. I’m assuming the attackers didn’t wear any uniforms or insignia.
> The extensive FBI investigation ultimately determined that members of the al Qaeda terrorist network planned and carried out the bombing.
[...]
> By the end of 2000, Yemeni authorities had arrested several suspects, including Jamal Muhammad Ahmad Al-Badawi and Fahad Muhammad Ahmad Al-Quso
(Source: https://www.fbi.gov/history/famous-cases/uss-cole-bombing)
You don't generally call in the FBI to "investigate" a military attack, or "arrest suspects".
If the nation of Yemen had immediately claimed responsibly for the exact same attack and declared war, it wouldn't have been considered terrorism, and rightfully so.
If the USS Cole bombers were rebels trying to gain their independence from Yemen (which I don't think is even their stated objective?) and not terrorists they would have been prioritizing Yemeni military targets, not those of uninvolved foreign nations.