> Pumped hydro is generally better for long term storage
Up to a point. Very long term storage is another thing again.
This twitter/X post has a very nice animated graphic of the predicted evolution of storage technologies over time (from 2020 to 2030), plotted against two attributes: duration of discharge, and # of cycles per year.
https://twitter.com/iain_staffell/status/1722544993179504965
Li-ion batteries and hydrogen are expanding the areas where they would dominate; pumped hydro is shrinking. Compressed air is getting squeezed out (no pun intended).