If your browser is compromised or can't be trusted then you have bigger problems.
But if we assume this site can be trusted not to send secrets online (which is easy to verify) and they are not rolling their own crypto primitives in javascript, then the idea is pretty sound imo.
Personally I would use gpg or openssl for this, but it's not that easy for non-technical users.