undefined | Better HN

0 pointswrs2y ago0 comments

Not sure what you mean? Our whole codebase is .ts files, and we use tsc and esbuild without apparent difficulty.

0 comments

7 comments · 1 top-level

conaclos2y ago· 6 in thread

I mean, if you have a file `mod.ts`, in Deno you cannot import `mod.ts` using the following import:

  import {} from "./mod.js"

You have to write:

  import {} from "./mod.ts"

ESbuild doesn't transform source imports. Thus, by transpiling your code using ESbuild, you get an erroneous import that leads to a runtime error in browsers and Node. The case is worse for TypeScript, because it refuses to tarnspile this code.

By the way, bundling with ESbuild is possible, however when you write a library you generally want to transpile the code, not to bundle it.

pipe012y ago

I use esbuild to import .ts regularly, I'm not sure how you came to that conclusion

conaclos2y ago

ESbuild correctly resolves the path, however it doesn't rewrite the import path. Thus, you end with a javascript file that tries to import a typescript file (this leads to a runtime error in the browser and Node).

wrsOP2y ago

We don’t put extensions on imports

    import {} from "./mod“;

and we bundle before running. Maybe that explains it.

conaclos2y ago

Yes. I transpile my libraries and in order to be ESM-compatible you have to use the extension of the emitted files (in my case `.js`)

iainmerrick2y ago

ESbuild has handled “.ts” imports for as long as I’ve used it.

TSC recently added a flag that allows “.ts” imports too.

conaclos2y ago

> ESbuild has handled “.ts” imports for as long as I’ve used it.

Yes, ESbuild correctly resolves the path, however it doesn't rewrite the import path. Thus, you end with a javascript file that tries to import a typescript file (this leads to a runtime error in the browser and Node).

> TSC recently added a flag that allows “.ts” imports too.

For type-checking only. You cannot emit code when using `ts` extension.

1 more reply

j / k navigate · click thread line to collapse