undefined | Better HN

0 pointsmplanchard3y ago0 comments

What do you mean by 100% code review?

0 comments

Every line of code must be code reviewed before it goes to stage/prod

… how else do people operate? Complete yolo?

Maybe rubber stamp PR? We can say we review everything 100%, but practically this sometimes just means clicking the approve button.

You’d be surprised how many places operate that way. Or better, commit to master via the web ui because “it’s a quick small fix”

lol. I've been doing this for a long time. It wasn't always done that way.

j / k navigate · click thread line to collapse

Every line of code must be code reviewed before it goes to stage/prod

xxpor3y ago

… how else do people operate? Complete yolo?

Maybe rubber stamp PR? We can say we review everything 100%, but practically this sometimes just means clicking the approve button.

You’d be surprised how many places operate that way. Or better, commit to master via the web ui because “it’s a quick small fix”

lol. I've been doing this for a long time. It wasn't always done that way.

j / k navigate · click thread line to collapse