It heavily depends on which army you are joining and what cause they fight for. Joining army can be step towards supporting atrocities and it can be step towards preventing them.
Just like with joining police - in some places it is good thing to do. In others, you are joining another criminal organization.