I'm severely green-blind and in the earlier screenshots of the Solarized palette I already hat issues telling red and orange, and blue and violet apart. But with the new palette I now struggle with red, orange AND green, and magenta and cyan also have become less distinct from each other.
Solarized wasn't very accessible to begin with (few syntax highlighting color palettes are) but this is just worse. If you learn about color theory as a hobby, please also take the time to learn about color vision and before making claims about accessibility also learn about how color vision deficiencies affect perception.
It's nice that the author admits they had to learn about color theory in order to approach this, i.e. they didn't know much about color before, but please don't claim this is an "improvement" if you really only tried to increase the light-dark contrast of the text against the background. Solarized is a fairly low-contrast theme to begin with and increasing its contrast while maintaining its general aesthetic would have been an interest goal but this article doesn't seem to actually be interested in doing that.
And for what it's worth, I ran this color scheme through filters simulating deuteranopia, protanopia, and tritanopia, and actually coded in them for at least a couple of hours each to see what it was like, and I personally preferred a consistent minimum foreground/background contrast over distinguishability between the accent hues.
I believe a color scheme or font should not, by default, take into account color blindness or dyslexia. I mean, we could do that, but the reward would be too low compared to the cost because the amount of people with such disability is too low compared to healthy amount. Instead, users should have the option to opt for a colorblind or dyslexia color scheme or font, just like there's lifts in public space but also stairs, and its assumed most users can use the stairs (else you'd get congestion). The only exception is things like traffic signs. But given HN is an American website, I believe the US is putting emphasis on written text on traffic signs where symbols (picture language) would suffice, and improve on the matter (not just because not all speak English but more because of reading taking more effort than observing a sign, leading to errors).
Most specifically "colorblind-friendly" color schemes suck. Most "regular" color schemes are at least partially accessible to colorblindness though. My complaint is that the author claimed the changes "preserve accessibility" while objectively making the theme less accessible. If the colors are indistinguishable in greyscale, that is not a good thing. Heck, there's not even one true way to determine what the "greyscale equivalent" of a given color is.
The author's initial complaint was that Solarized doesn't have enough light-dark contrast between the text and the background and took a stab at solving this after reading a little bit about color theory.
Don't get me wrong, this is an interesting hack (which makes this relevant for HN) but my concern is with the author making misleading accessibility claims and calling it an "optimized" or "improved" theme (to the point that others have commented they are downloading and using it themselves) while clearly demonstrating a lack of understanding of accessibility and admitting to having a very limited knowledge of "color theory".
Specifically, there was no need to homogenize the colors like this in order to increase the light-dark contrast of the theme. Even from a design aspect alone it made the theme blander, less interesting. The author lacks the knowledge to understand what makes the theme work, so how can they claim they have improved upon it?
Again, it's an interesting hack and a fun creative exercise and the result may even serve the author's and others' needs. But neither did it "preserve accessibility", nor did it "improve" nor "optimize" the theme. Your argument seems to be that restricting color palettes to make them more accessible by default limits creative choices, but my point is that arbitrarily pinning the lightness as an amateur attempt at improving light-dark contrast has this exact same effect (i.e. making the result less interesting) while additionally making the result less accessible.
In particular, respecting the ANSI colour codes makes pretty much every programme work great out of the box. I respect that Solarized tried to pack the entire colour scheme into the ANSI colour codes, but the occasional breakages are less than ideal.
However, the author did improve the contrast when looking at the numbers. I ran the default text color through a contrast check and see this results (I hope I took the correct colors):
solarized: https://webaim.org/resources/contrastchecker/?fcolor=657B83&... (4.12:1)
OkSolar: https://webaim.org/resources/contrastchecker/?fcolor=657377&... (4.6:1)
selenized: https://webaim.org/resources/contrastchecker/?fcolor=53676D&... (5.36:1)
So this is likely better, but not as accessible as selenized. When looking at the writeup there was maybe a bit too much focus on equal color contrast vs raising the contrast in general? Regardless, this is a nice evolution, and the equal contrast approach combined with selenized higher contrast approach could make for the perfect combination.
I guess the same very low contrast is a problem for the light one too. This here did not improve it.
Nowadays I mostly use something else.
I took some dark theme (twilight anti-bright from emacs) and just tweaked some values to my liking (making background darker was one), then moved with same theme (manually...) to IntelliJ IDEA and few other apps
Generally, OKLab is its own independent color space. It's not like HSV for example, which is just a transformation of sRGB.
I have always thought this with Solarized, on many monitors over many years. Perhaps my eyes aren't as good as others, but i found it instantly fatiguing
Isn't a significant part of a colour scheme the ability to more easily distinguish between elements? In my terminal and text editor I want to pick out the relevant information quickly.
I hate asking stuff like this because it sounds like I'm dismissive of the really cool article/experiment I just read.
Strange. For the dark scheme, it fixes the saturation and lightness difference between colors, but it doesn't seem to improve the contrast ... at all? Are my eyes lying to me? You decide: https://i.imgur.com/vFa06CE.png
I think this is an interesting approach, maybe I'll try using it with a significantly darker background color.
Author links to a json file https://meat.io/oksolar.json but haven't done manual jetbrains theming so hoping more experienced eyes have taken a stab at it.
