undefined | Better HN

0 pointswindows_sucks3y ago0 comments

    make_pepperoni_pizza()
     is bad code compared to
     make_pizza(toppings=[PEPPERONI])

How would you make Hawaiian pizza? I forget, does it include Ham? or just pineapple? you're forced to the remember that nuance in your suggested implementation, but not with "make_hawaiian_pizza()"

0 comments

1 comments · 1 top-level

frognumber3y ago

It's data.

   make_pizza(toppings=HAWAIIAN_TOPPINGS)

   make_pizza(HAWAIIAN)

or similar. Data should generally not be hard-coded, both because it changes and because it wants to be validated. Starting with:

   HAWAIIAN = { TOPPINGS: [ PINEAPPLE  ...

is okay. That can later be loaded from a config file, a database, or otherwise, as the system expands.

1 more reply

j / k navigate · click thread line to collapse