undefined | Better HN

0 pointssteve_adams_864y ago0 comments

I’ve been running into circularity bugs lately as well… I think. It’s incredibly hard to tell if you’re doing something dumb or it’s a legitimate bug.

Do you know of an issue that’s tracking a specific bug related to the circularity issue you’re seeing in createSlice?

0 comments

2 comments · 1 top-level

acemarke4y ago· 1 in thread

Not specifically. The general problem we were running into is:

- We recommend inferring `type RootState = ReturnType<typeof store.getState>`

- That type comes from the slice reducers

- Thunks need a `State` type passed in so they know what `getState` returns

- But if you do that _inside_ of `createSlice`, TS can't know that `RootState` type yet, because we haven't constructed the slice reducer yet

Here was the PR where we tried to come up with something:

https://github.com/reduxjs/redux-toolkit/pull/637

If you're seeing some other issue problem related to RTK, please go ahead and file an issue.

steve_adams_86OP4y ago

Sorry, I should have specified that it’s in work unrelated to RTK. I was just curious if the bugs we encounter are the same ones.

Unfortunately the circularity issues that are closely tracked in the TypeScript repo don’t seem to be making much progress, and in some cases, it seems like TS is fundamentally incapable of working with circular references in some contexts.

Like I was saying though, I find it hard to tell at times if I’m running into real limitations of the type system or I’m short a few IQ points, haha.

j / k navigate · click thread line to collapse