undefined | Better HN

0 pointsbradwood4y ago0 comments

Code review != Testing.

A lot of people conflate these IMHO. Code review should not really be about whether it "works" or not. That's what tests are for.

Code reviews are about checking for code complexity, good use of abstractions, readability, etc.

0 comments

this should be the most upvoted comment

You have to review tests and you are back at square one.

What's the point of checking for those if the bar for fully functional isn't met?

None. So don't do the review until CI passes.

And also to spread knowledge of aspects of the system across the team.

j / k navigate · click thread line to collapse