undefined | Better HN

0 pointsOJFord4y ago0 comments

My preference is actually for what GP doesn't like; the reason I don't like your suggestion is that:

    from typing import (
        overload,
    )

is silly, but I don't want:

    -from typing import overload
    +from typing import (
    +    overload,
    +    List,
    +)

when all I actually did (semantically) was:

    +    List,

0 comments

mrtranscendence4y ago

It feels to me like importing names from a module gets you a set of names from that module, so I'm already thinking about it as a collection. It doesn't bother me at all that it's turned into a tuple and spread over multiple lines.

OJFordOP4y ago

I think I prefer it (first example) to the diff (second), it's just that a singular thing imported is such a common case that three lines for it where it so easily fits on one does seem a bit silly.

Maybe if I were allowed new syntax:

    from typing:
        import overload
        import List

j / k navigate · click thread line to collapse