I don't read the parent comment as saying that vscode shouldn't be written in electron. I read it as the opposite, that they are defending the terminal emulator using electron.
Also, out of interest, what reasons would you give for vscode being written with electron?