undefined | Better HN

0 pointsninkendo4y ago0 comments

Sure, that’s exactly what I’m advocating for? I’m confused.

You said it’s a waste of time to do this and to just squash when merging instead. I’m saying I’d rather squash first so that my PR looks clean and doesn’t contain my WIP commits. Then you respond saying “well you can just squash before your PR then”… are we going in circles?

0 comments

_hao4y ago

Your use case is a bit different than what the article is arguing for. If you have a personal preference to have everything shown as a single commit in the PR by all means do things the way outlined above.

My original comment was targeting the two supposed problems that the article is framing and the supposed convoluted (and possibly dangerous) solution with git reset.

j / k navigate · click thread line to collapse

0 pointsninkendo4y ago0 comments

Sure, that’s exactly what I’m advocating for? I’m confused.

0 comments

_hao4y ago

My original comment was targeting the two supposed problems that the article is framing and the supposed convoluted (and possibly dangerous) solution with git reset.

j / k navigate · click thread line to collapse