> Apple hashes all of your photos offline [...]
No, only the ones designated for upload to iCloud.
> [...] it’s about governments forcing Apple to do things with this new weapon
Governments can already force Apple to do any kind of scanning, "weapon" being built already or not.