undefined | Better HN

0 pointszelphirkalt4y ago0 comments

I get it, JS is a weird language, but simple things like "is number" are still easy enough to do in JS, especially, when ints and floats are all just "number" in JS:

function is_number(val) { return typeof val === "number"; }

With a function that easily written, no one should have any excuse to depend on a third-party dependency for it.

0 comments

tshaddox4y ago

But the code you posted is not what the code in this package does. If all you need is the code that you posted, then you should absolutely use that.

kinjba114y ago

> not what the code in this package does

Here's `is-number` (https://github.com/jonschlinkert/is-number/blob/master/index...):

    module.exports = function(num) {
      if (typeof num === 'number') {
        return num - num === 0;
      }
      if (typeof num === 'string' && num.trim() !== '') {
        return Number.isFinite ? Number.isFinite(+num) : isFinite(+num);
      }
      return false;
    };

Care to explain why these 5 lines of code need to be a package? To me, having something so simple be a package by itself is absurd.

tshaddox4y ago

Note that there’s a difference between “needs to be a package” and “needs to be used by everyone.” Nothing needs to be a package, because it’s always possible to copy paste code, regardless of how many lines it is.

j / k navigate · click thread line to collapse

0 comments

tshaddox4y ago

But the code you posted is not what the code in this package does. If all you need is the code that you posted, then you should absolutely use that.

kinjba114y ago

> not what the code in this package does

Here's `is-number` (https://github.com/jonschlinkert/is-number/blob/master/index...):

    module.exports = function(num) {
      if (typeof num === 'number') {
        return num - num === 0;
      }
      if (typeof num === 'string' && num.trim() !== '') {
        return Number.isFinite ? Number.isFinite(+num) : isFinite(+num);
      }
      return false;
    };

Care to explain why these 5 lines of code need to be a package? To me, having something so simple be a package by itself is absurd.

tshaddox4y ago

j / k navigate · click thread line to collapse