That depends who you ask, but there are two types of trolls. The first, as you describe, basically extort small settlements out of companies using garbage patents--the classic example being the guys who sued small businesses for using a fax machine.

The second are non-practicing entities that buy at least half-way decent portfolios for cheap and then sue big businesses for big settlements or big jury verdicts. Their lawyers can be very good.