As long as the maintainers are responsive to bug fixes and key feature requirements (since they aren’t accepting of outside contributors adding them), then this is fine, possibly even optimal in terms of quality.
The trouble comes in if they both don’t allow many outside contributions and at the same time they pull the same unjustified complaint of a lot of OSS and say because they aren’t paid for their time, they will prioritize what interests them rather than what resolves painpoints or missing features users need. You definitely can’t have it both ways.
I wonder how you justify that, because I'm currently maintaining a vue project in production and couldn't disagree more (honest question)
I am sure majority of developers have had two or more projects using the same framework/library and found the difficulty of maintaining them different.
Vue may be right or wrong, but nobody wishing for special case features can claim to be surprised. If you picked Vue knowing you need a bunch of special case features, that’s on you.
Which is much easier to attain if you're comfortable with only a single person being allowed to write code. Personally, I wouldn't use Vue in any business-oriented application for this exact reason. The "bus factor", or as I would call it, "If and when Evan decides to stop caring about Vue", is enough to make Vue dead in the water as a legitimate FE library choice (to me).
In my personal experience, the acceptance rates doesn't really matter and does not correlate to the quality of the code. On one hand, you have SQLite which really discourages direct code submissions due to the nature of the IP management of SQLite (they need to ensure that it is 100% in public domain), instead relying on bug reports instead. SQLite however is a very good product, something that I personally miss when I work on JS projects.
On the other hand, I've seen projects (multiple, which I prefer not naming to prevent flame wars) with very high acceptance rates - the problem is that the coding style and availability of comments are inconsistent to the point that we have to forego using some libraries and writing our own despite those libraries will fit into the bill nicely.
Edit: some have commented "this is what I've expected!", but there are some projects (obviously will be unnamed) that are not accepting contributions but the code consistency is less-than-ideal, and some projects with well-behaved outside contributors that have kept the quality despite having high acceptance rates (usually writing in relatively niche languages). Probably the area I'm working on (educational) isn't reflective on the wider community, which seems to associate higher rejection rates to quality.
At least I would prefer to use sqlite over indexeddb, but haven't found a way yet.
https://github.com/vuejs/vue/pull/11847/files
https://github.com/vuejs/vue/pull/11853/files
https://github.com/vuejs/vue/pull/11820/files
https://github.com/vuejs/vue/pull/11818/files
All within the last month.
Maybe there's some tutorial for 'how to submit a PR on GitHub' that links to Vue.js and people are following that?
We as developers need to do better and support people like Evan out there.
Eventually, we should also hold individual engineers who work at Facebook/similar accountable to a higher standard and reject their software even if it’s open source or wonderful (React).
When backdoors are added to your service framework, when dragnet data collection services copy every artifact of your digital existence in the name of "national security" or when algorithms have been trained to distinguish faces specificly of your race you will damn sure want to know who wrote that code and why. Its just naive to think tools exist outside of their intended function and political ends often determine those functions.
Which is why I disagree with Vue (and others) putting gigantic BLM banners on their sites.
Even if the cause is just, by mixing in politics, you create less of a common ground for those working on and using the code, thus creating rifts where there need not be any. Everything becomes "us" and "them".
I suggest you read Larry Lessig's Code 2.0 book.
https://www.vanderbilt.edu/oacs/wp-content/uploads/sites/140...
Vue 3 (70.62% acceptance): https://merge-chance.info/target?repo=vuejs/vue-next
Svelte (57.23% acceptance): https://merge-chance.info/target?repo=sveltejs/svelte
React (45.99% acceptance): https://merge-chance.info/target?repo=facebook/react
Angular (1.63% acceptance): https://merge-chance.info/target?repo=angular/angular
so what does this contextless number you submitted here tells us about that? Please be careful with spreading around stats like that without context.
This title should read: Vue accepts 70% of outside contributions on latest version and only 23% on old version.
https://gh-api.clickhouse.tech/play?user=play#U0VMRUNUCiAgIC...
