If you want better privacy, don't continue to let companies who lie about providing better privacy get away with it. So far, I haven't seen Google deliberately lie about the privacy of their services. That should be the bare minimum that we expect.
Apple, for its part, says "Apple doesn’t retain a history of what you’ve searched for or where you’ve been" and there's no reason to doubt it.
1: https://www.azag.gov/press-release/attorney-general-mark-brn...
I would just apply Hanlon's razor here. It most likely was a bug or oversight, if it had been some malicious evil scheme, I would assume more care would have been taken so that people don't find out.
Now, coming to the question of why do they even store it for opted in users?
Aside from potential ad relevance, I think it is simply because they power a lot of their features with context and they get better with data.
For example, if you search cheesecake on Google, the answer likely will be either a recipe or a restaurant. A restaurant search will likely be helped by data about previous visits and current location. A recipe search will be helped by past search result clicks and again location.
Do they really need to store this to serve search results? I don't think so. DDG works without them, but then again DDG performs very poor for queries like this which can be helped with context.
Note: I don't know how any of this exactly works, so these are just my assumptions.
The GDPR consent prompt they recently implemented on Google & YouTube is not actually GDPR compliant and does not offer an easy way to opt-out.
I can go on and on. I'm not saying Apple is perfect (a lot of the points you raised are valid), but it's sure as hell better than a company whose entire bottom-line is based on stalking people.
Not defending them but is it forced? I remember being asked about it. I used to keep it off for a long time but keep it on now to keep track of places I visit.
> there is no technical reason for this.
I have seen them give you best time to leave from home/office for/after work based on developing traffic as notifications. Same for reminders of events in calendar with location context.
Also, just my assumption but they might be adding locality context to searches.