Do it. My Galaxy S with 2.2 is so much better than with 2.1 that it seems like a different phone. It's faster, more stable, the battery lasts longer. I wish I'd done it sooner.
Agreed - even I upgraded my Galaxy S (Vibrant) to Gingerbread Clone (eb-productions) and have better battery life and an amazingly accurate battery life widget.