I think, based purely on the separation of concerns, it'd be good if states wouldn't finance loans to companies.
It's problematic, because it's hard for states to provide equal treatment (ever firm should be equal in the eyes of the law), states shouldn't be in the business of analyzing business plans and taking on risk.
That said, NY would have probably benefited from HQ2, though it's not that there's a lack of upward forces on the salaries of those jobs there, not to mention real estate.