I’ve been using Github for notes recently after trying some other alternatives from your AskHN question, and GH has been good so far, particularly for easily writing notes in markdown, and grouping notes in subfolders within repos.
My main criticism is that it’s not convenient to use Github on mobile and there’s no official app. I just request desktop site in mobile Safari, but the UX is a struggle when creating and editing files.