Disclaimer: not trying to convince you, just sharing an anecdote like you did.
- I agree Apple pricing has gone out of control. I should not have to shell out 1500 EUR for a 256GB phone with a bigger display no matter what (XS Max). I mean okay, it's probably the best phone out there but come on. It's a mobile computing device, not a life's insurance bill.
- I fully agree MacBooks and desktop Macs haven't had good years in a while. IMO the MacBook Pro 2015 15" was Apple's laptop peak. They haven't produced anything worthwhile in the laptop departments ever since.
- Desktop Macs are a horrid mess where greed trumps everything else so much that even I who spent 6 figures on tech during my life cannot justify paying 5000 EUR for an iMac 27" 5K with maxed out specs (i7 CPU, 64GB RAM and 1 or 2TB SSD). Right now your only viable choice for a future-proof machine however is either the iMac 27" or the iMac Pro, and both are expensive as hell.
- macOS version, not sure, I started actively using it only a year or so ago so it feels quite good to me and is tons more predictable than Windows 10. You have to fight with Windows 10 to make it your own and not be barraged with popups. macOS in comparison stays out of the way.
---
To summarize, Apple has peaked, including in the smartphone and tablet departments. Upgrades are very smallish and iterative while the price tags remain huge.
The way I see it, Apple has been coasting for a while. They need to get back on track because inevitably somebody will try and displace them.
(As a random example, Xiaomi phones are probably the best physical designs and software experience I ever had. But I still don't trust Google's binary blobs and the general baseband processor stuff so I stay away from Android.)