Rooting is nice, and I believe it's important from a philosophical standpoint, but I probably won't with my next phone because the features I want are getting built into the OS, and I am missing several apps that just refuse to work when they detect they're running on a rooted phone. (Everything from games to my work email.)

It definitely increases the longevity of phon but, while it mostly works, it has lots of little quirks - especially with the various radios. E.g. I occasionally have to re-pair bluetooth devices, wi-fi will disconnect and then re-connect for no apparent reason, etc. Also, sometimes I just find it getting warm in my pocket and I have to reboot it to make it snap out of whatever endless loop it's stuck in. (I assume that updating to LineageOS will fix a few bugs and introduce a few others.)

I'm going to replace it with either the next Pixel or the next iPhone when they both get released in a month or two, depending on which one I'm more impressed with. I am going to miss my headphones jack...