undefined | Better HN

0 pointspmarreck8y ago0 comments

> The thing is that most of the conditionals were never hit under ideal conditions (like passing all args etc.).

Your debugging work in this case might have also been alleviated by a good unit test covering this functionality.

0 comments

It would have been. But it wasn't my code, I was merely using it. I think better structuring would have helped the code much more than unit tests. Unit tests are good to ensure you don't break things. But spaghetti code that passes tests is still considered broken by my standards.

pmarreckOP8y ago

> I think better structuring would have helped the code much more than unit tests.

This is why you TDD. Your code will automatically become more modular/structured by the very nature of having to unit-test it "right then and there" instead of hours later when you finished the component without any tests and decide to bang out a few basic integration tests and then head to happy hour and call it a day.

> Unit tests are good to ensure you don't break things. But spaghetti code that passes tests is still considered broken by my standards.

I agree, that's still technical debt. You literally cannot write spaghetti code if you TDD, though. You would feel a massive friction.

j / k navigate · click thread line to collapse