If I manage to figure out that Company A is overvalued compared to Company B, and I short Company A in order to buy stock in Company B then by doing so, in a simple supply-and-demand model... Company A's stock will go down very slightly (because I shorted them), and Company B's stock will go up slightly (because I bought their stock).
A higher stock value helps a company - they can sell some of their own stock in order to raise more funds. Therefore, the value I've provided is I've made a calculated decision that the economy should be spending more on (for example) robotics and less on coal because robotics companies are going to more successful, and coal less successful.
Allocating funds to the more profitable companies and industries is one of the strengths of the market economy - it adds efficiency.
Price-finding in general adds value. Also market liquidity adds value. I wouldn't discount what these people do, even if they are narcissistic selfish assholes as a breed.