It's not a problem that their ranking is based on optimizing for income, since they state upfront what they are ranking them on. However, it could be a problem that not all of the students included in the data are optimizing for that. A school that was very good at helping students increase their potential income, but that attracted mostly students who aren't interested in maximizing income would be ranked low, but it should receive a high rank.