The main negative effect of helmet laws that I've seen cited is that they reduce the popularity of cycling as a transportation mode, and that can have extremely negative effects on public health (due to increased driving, reduced physical activity, and indirectly as a general damper on pro-cycling sentiment and infrastructure changes).
[I think Australia's helmet law is one of the main examples people talk about.]